-
Couldn't load subscription status.
- Fork 230
Update changelog for components and provider #7120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CHANGELOG.md
Outdated
| - Fix `und-SA-u-ca-islamic` (unicode-org#6736) | ||
| - Add RataDie::in_well_behaved_astronomical_range(), use to avoid panics (unicode-org#6876) | ||
| - Improve some Gregorian calendar code (unicode-org#6870) | ||
| - Fix Hebrew MonthDay resolution with M05L (unicode-org#6966) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We don't need to document fixes on previous larger changes. If you want you can move this link to be in the list of links of try_from_fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I just didn't pick up on the fact that this was MonthDay
| - Modifier_Combining_Mark | ||
| - `icu_segmenter` | ||
| - Experimental (internal) code for convolutional neural network segmenter (unicode-org#6877) | ||
| - `icu_time` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought: I'm happy that our splitting out this stuff from the icu_calendar crate helps organize the changelog better.
| - `icu_calendar` | ||
| - Fix `und-SA-u-ca-islamic` (unicode-org#6736) | ||
| - Add `Date::try_from_fields` for flexibly building Temporal dates (unicode-org#6910) | ||
| - (unstable) Implement date arithmetic according to Temporal specification (unicode-org#6992, unicode-org#7012) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather not advertise unstable code in the change log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, yes, but this is a very important thing about this release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and we can directly communicate it to clients that need it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm? We have always advertised improvements to experimental code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(a) This is an API that has been experimental but unchanged for a long time and we're changing it, which is worth advertising
(b) this API is something near stabilization and advertising it to get additional user feedback is valuable
Progress on #7080